Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor training loop from script to class #46

Closed
wants to merge 2 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 13, 2023

Description

This PR refactors the training loop from a script format to a class format for better organization and reusability. The training loop code is currently in the file src/main.py and has been moved into a new class named MNISTTrainer. The class encapsulates the training loop and related functionality, allowing for easy instantiation and use in other parts of the codebase.

Summary of Changes

  • In src/main.py:

    • Created a new class named MNISTTrainer to encapsulate the training loop and related functionality.
    • Moved the code for loading and preprocessing the MNIST data into a method named load_data.
    • Moved the code for defining the PyTorch model into a method named define_model.
    • Created a new method named train_model to implement the training loop.
    • Created a new method named save_model to save the trained model to a file.
    • Updated docstrings and comments to reflect the changes.
  • In src/api.py:

    • Imported the MNISTTrainer class from src/main.py.
    • Replaced the code for loading the model with an instantiation of the MNISTTrainer class and a call to its load_model method.
    • Updated docstrings and comments to reflect the changes.

These changes improve the organization and reusability of the training loop code, making it easier to maintain and use in other parts of the codebase.

Fixes #6.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Rollback Files For Sweep

  • Rollback changes to src/api.py
  • Rollback changes to src/main.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@sweep-nightly sweep-nightly bot added the sweep label Oct 13, 2023
@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: refactor the training loop from a script to a class in main.py
1 participant