Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor training loop from script to class #8

Closed
wants to merge 1 commit into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 12, 2023

Description

This PR refactors the training loop from a script to a class in order to improve code modularity and maintainability. The training loop, previously located in src/main.py, has been moved to a new class called Trainer. The Trainer class takes the model, optimizer, loss function, and training data loader as parameters and encapsulates the training process.

Summary of Changes

  • Created a new class Trainer in src/main.py to encapsulate the training loop.
  • Moved the training loop logic from the script to the train method of the Trainer class.
  • Updated src/main.py to instantiate the Trainer class and call the train method.
  • Imported the Trainer class in src/api.py to ensure compatibility with the existing code.

These changes improve code organization and make it easier to maintain and test the training process. The functionality of the existing code in src/api.py is preserved, as the trained model is still saved to the same file and loaded by the API.

Fixes #6.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 12, 2023

Rollback Files For Sweep

  • Rollback changes to src/main.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: refactor the training loop from a script to a class in main.py
1 participant