Skip to content

Commit

Permalink
review_pr restrictions (#3738)
Browse files Browse the repository at this point in the history
only run review_pr if it there are no restrictions (no .env var
PR_REVIEW_REPOS or if the .env var exists the repo name is in the .env
var)

Co-authored-by: Martin Ye <[email protected]>
  • Loading branch information
MartinYe1234 and Martin Ye authored May 14, 2024
1 parent 4d9065b commit 361a7d0
Showing 1 changed file with 23 additions and 14 deletions.
37 changes: 23 additions & 14 deletions sweepai/api.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import ctypes
import os
import threading
import time
from typing import Any, Optional
Expand Down Expand Up @@ -513,13 +514,17 @@ def handle_event(request_dict, event):
_, g = get_github_client(request_dict["installation"]["id"])
repo = g.get_repo(request_dict["repository"]["full_name"])
pr = repo.get_pull(request_dict["pull_request"]["number"])
# run pr review
call_review_pr(
username=pr.user.login,
pr=pr,
repository=repo,
installation_id=pr_request.installation.id,
)
# check if review_pr is restricted
allowed_repos = os.environ.get("PR_REVIEW_REPOS", "")
allowed_repos_set = set(allowed_repos.split(',')) if allowed_repos else set()
if not allowed_repos or repo.name in allowed_repos_set:
# run pr review
call_review_pr(
username=pr.user.login,
pr=pr,
repository=repo,
installation_id=pr_request.installation.id,
)
except Exception as e:
logger.exception(f"Failed to review PR: {e}")
raise e
Expand Down Expand Up @@ -893,13 +898,17 @@ def handle_event(request_dict, event):
_, g = get_github_client(request.installation.id)
repo = g.get_repo(request.repository.full_name)
pr = repo.get_pull(request.pull_request.number)
# run pr review
call_review_pr(
username=pr.user.login,
pr=pr,
repository=repo,
installation_id=request.installation.id,
)
# check if review_pr is restricted
allowed_repos = os.environ.get("PR_REVIEW_REPOS", "")
allowed_repos_set = set(allowed_repos.split(',')) if allowed_repos else set()
if not allowed_repos or repo.name in allowed_repos_set:
# run pr review
call_review_pr(
username=pr.user.login,
pr=pr,
repository=repo,
installation_id=request.installation.id,
)
except Exception as e:
logger.exception(f"Failed to review PR: {e}")
raise e
Expand Down

0 comments on commit 361a7d0

Please sign in to comment.