This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
WIP: Add necessary changes for L2C track loop #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adel-mamin Please, review. |
|
Looks good to me. |
| @@ -56,10 +59,6 @@ | |||
| * \note This is GPS_C / mu where mu is 1.0002926 */ | |||
| #define GPS_C_NO_VAC (GPS_C / 1.0002926) | |||
|
|
|||
| /** The wavelength of L1 in a vacuum. | |||
| * \note This is GPS_C / GPS_L1_HZ. */ | |||
| #define GPS_L1_LAMBDA (GPS_C / GPS_L1_HZ) | |||
There was a problem hiding this comment.
This was removed to avoid implementing one more utility function like code_to_carr_freq. There is only place (observation.c) where the macro is used so I simple changed it with GPS_C/code_to_carr_freq(e[i]->sid.code) see below.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains necessary updates for swift-nav/piksi_firmware#618 and should be merged before it..