README: improve KafkaProducer examples
#76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motiviation: * align `KafkaProducer` more with proposed changes to `KafkaConsumer` * `AsyncStream` was not handling `AsyncSequence` termination handling as we wanted it to, so revert back to use `NIOAsyncSequenceProducer` Modifications: * make `KafkaProducer` `final class` instead of `actor` * `KafkaProducer`: use `NIOAsyncSequenceProducer` instead of `AsyncSequence` for better termination handling -> shutdown `KafkaProducer` on termination of the `AsyncSequence` * introduce `StateMachine` to `KafkaProducer` * move internal state of `KafkaProducer` to `KafkaProducer.StateMachine` * remove unused `await` expressions when accessing `KafkaProducer` * update tests * update `README`
Modifications:
* `README`:
* add example for `KafkaProducer` without acknowledgements
* remove `KafkaProducer.shutdownGracefully` invocation for
acknowledgement producer
FranzBusch
reviewed
Jun 28, 2023
|
|
||
| let producer = try KafkaProducer.makeProducer( | ||
| config: config, | ||
| logger: .kafkaTest // Your logger here |
There was a problem hiding this comment.
We normally just do this
Suggested change
| logger: .kafkaTest // Your logger here | |
| logger: logger |
Comment on lines
+54
to
+55
| // Required | ||
| await producer.shutdownGracefully() |
There was a problem hiding this comment.
We really want to get rid of this by folding it into the run() method. Maybe let's not add this to the example here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications:
README:KafkaProducerwithout acknowledgementsKafkaProducer.shutdownGracefullyinvocation for