Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[target] .swift_ast section is a metadata section #9678

Open
wants to merge 1 commit into
base: stable/20240723
Choose a base branch
from

Conversation

hyp
Copy link

@hyp hyp commented Dec 3, 2024

This change ensures that this section is not marked as loadable, which makes it possible for it to be stripped. The swift_ast section holds the raw Swift module bytes that are needed by LLDB, but that are not required at runtime.

(cherry picked from commit 555eaef)

This change ensures that this section is not marked as loadable, which makes it possible for it to be stripped. The swift_ast section holds the raw Swift module bytes that are needed by LLDB, but that are not required at runtime.

(cherry picked from commit 555eaef)
@hyp hyp requested a review from a team as a code owner December 3, 2024 01:10
@hyp
Copy link
Author

hyp commented Dec 3, 2024

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, although it really feels like we should pull this "is a strippable Swift metadata section" check out into its own function.

@hyp
Copy link
Author

hyp commented Dec 4, 2024

@swift-ci please test

@hyp
Copy link
Author

hyp commented Dec 4, 2024

@swift-ci please test linux platform

3 similar comments
@hyp
Copy link
Author

hyp commented Dec 4, 2024

@swift-ci please test linux platform

@hyp
Copy link
Author

hyp commented Dec 5, 2024

@swift-ci please test linux platform

@hyp
Copy link
Author

hyp commented Dec 6, 2024

@swift-ci please test linux platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants