[lldb] Add an expression evaluation test for modules built with ... #9809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
force-pushed
the
test-enable-testing
branch
from
de8398e to
08233a5
Compare
adrian-prantl
approved these changes
Jan 10, 2025
-enable-testing and -enable-library-evolution -enable-testing affects the visibility of types, which together with -enable-library-evolution may cause the compiler embedded in LLDB to generate incorrect code on expression evaluation.
Add more resilience tests with a public superclass that is generic and inherits from an objc type and a non-public subclass with a property we access on the test. The tests vary in which modules the types exist (one resilient executable, one resilient library and non resilient executable, 2 resilient libraries and one resilient executable).
augusto2112
force-pushed
the
test-enable-testing
branch
from
08233a5 to
e94df26
Compare
1 similar comment
| class TestSwiftResilienceSuperclass(TestBase): | ||
| @skipUnlessDarwin | ||
| @swiftTest | ||
| def test(self): |
There was a problem hiding this comment.
Suggested change
| def test(self): | |
| def test(self): | |
| """ | |
| This test tests that ... | |
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-enable-testing and -enable-library-evolution
-enable-testing affects the visibility of types, which together with -enable-library-evolution may cause the compiler embedded in LLDB to generate incorrect code on expression evaluation.