feat: Add Semantic modifier to parameter labels #1542
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrayJack
commented
Jul 1, 2024
GrayJack
commented
ahoppen
reviewed
Jul 2, 2024
Sources/LanguageServerProtocol/SupportTypes/SemanticTokenModifiers.swift
Outdated
Show resolved
Hide resolved
ahoppen
reviewed
Jul 2, 2024
| @@ -905,7 +905,7 @@ final class SemanticTokensTests: XCTestCase { | |||
| expected: [ | |||
| TokenSpec(marker: "1️⃣", length: 4, kind: .keyword), | |||
| TokenSpec(marker: "2️⃣", length: 3, kind: .identifier), | |||
| TokenSpec(marker: "3️⃣", length: 3, kind: .function), | |||
| TokenSpec(marker: "3️⃣", length: 3, kind: .function, modifiers: .argumentLabel), | |||
| TokenSpec(marker: "4️⃣", length: 3, kind: .struct, modifiers: .defaultLibrary), | |||
| TokenSpec(marker: "5️⃣", length: 3, kind: .function), | |||
| TokenSpec(marker: "6️⃣", length: 3, kind: .function), | |||
There was a problem hiding this comment.
Shouldn’t this token also have a .argumentLabel modifier?
Also in case you see the test as being skipped on your machine, you need to set SOURCEKIT_TOOLCHAIN_PATH to a Swift Development Snapshot as described here: https://github.com/swiftlang/sourcekit-lsp/blob/main/CONTRIBUTING.md#selecting-a-toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.