-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code listing style fixes, remove extra line management #667
Code listing style fixes, remove extra line management #667
Conversation
@Kyle-Ye give this a try and let me know :) |
Tried it. It seems to fix all the bug I know. Thanks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Looks like this fixes both the tutorial and multiple line literal issue, and I also wasn't able to find any obvious regressions with any other complicated code listing we might render, like API Changes, collapsible REST code listings, etc
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to look good now 💯
@swift-ci test |
* Fix extra empty line issue on tutorial * refactor: change the CodeListing rendering Co-authored-by: Kyle <[email protected]>
* Fix extra empty line issue on tutorial * refactor: change the CodeListing rendering Co-authored-by: Kyle <[email protected]> rdar://109756906
closes #662
rdar://109756906
Summary
This PR refactors the css styling of the CodeListing in order to properly render new lines coming from code.
Dependencies
Testing
This PR should be tested with as many examples as possible, across Tutorials and Doc pages.
We should test with scrollable content, multi-line content, and any combination of them.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
Added tests- css mostlynpm test
, and it succeeded