use default branches for unknown symbol kinds
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
I confirmed in a local build that this change still works with swiftlang/swift-docc-symbolkit#7 applied, which would have otherwise been a breaking change. |
ethan-kusters
approved these changes
Apr 8, 2022
|
@swift-ci Please test |
franklinsch
pushed a commit
to franklinsch/swift-docc
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tweaks how swift-docc uses
KindIdentifierinstances from SymbolKit. Instead of matching on an explicit.unknowncase (and using an exhaustive match), it instead changes them todefaultbranches, to catch any new cases as they're added. This allows us to add new symbol kinds to SymbolKit (e.g. swiftlang/swift-docc-symbolkit#21) without creating a source-breaking change.Dependencies
N/A
Testing
Existing functionality should remain unchanged.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded