Update examples in 0458-strict-memory-safety.md #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some errors in the examples
DougGregor
reviewed
Jan 21, 2025
| guard i != j else { return } | ||
| precondition(i >= 0 && j >= 0) | ||
| precondition(unsafe i < endIndex && j < endIndex) | ||
| precondition(i < endIndex && j < endIndex) |
There was a problem hiding this comment.
According to the current proposal, the unsafe is needed with the endIndex because of the implicit self being of an unsafe type. There is discussion on the review thread about how we might avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses two examples:
The text introducing the updated version of the
sum()example is "The warning-free version of this code is:", but the code sample still includes the warning. This change removes the warning.The
swapAtimplementation has two issues:Index(orInt?), notElementiandjare beforeendIndexshould not have anunsafekeyword, sinceendIndexis designated as@safe.