Initiating a Locale/Language with empty language code/script/region results in an unreasonable locale. #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults in an unreasonable locale. Here are some examples: ```swift print(Locale(languageCode: "", script: "", languageRegion: "").identifier) // "-_" let languageComponents = Locale.Language.Components(language: .init(identifier:"")) print(Locale(languageComponents: languageComponents).identifier) // "-Latn" ``` Fix this by handling empty identifiers passed in at initialization time correctly. resolves 132353443
itingliu
commented
Dec 20, 2024
| XCTAssertEqual(emptyLocale.language.languageCode, nil) | ||
| XCTAssertEqual(emptyLocale.language.script, nil) | ||
| XCTAssertEqual(emptyLocale.language.region, nil) | ||
| XCTAssertEqual(emptyLocale.language.maximalIdentifier, "") |
There was a problem hiding this comment.
Currently returns "en-Latn-US"
| XCTAssertEqual(emptyLocale.language.script, nil) | ||
| XCTAssertEqual(emptyLocale.language.region, nil) | ||
| XCTAssertEqual(emptyLocale.language.maximalIdentifier, "") | ||
| XCTAssertEqual(emptyLocale.language.minimalIdentifier, "") |
There was a problem hiding this comment.
Currently returns "en"
|
|
||
| let emptyLocale = Locale(identifier: "") | ||
| XCTAssertEqual(emptyLocale.language.languageCode, nil) | ||
| XCTAssertEqual(emptyLocale.language.script, nil) |
There was a problem hiding this comment.
Currently returns "Latn"
|
@swift-ci please test |
parkera
reviewed
Jan 10, 2025
| @@ -34,11 +34,11 @@ extension Locale { | |||
| if let languageCode = languageCode { | |||
| result += languageCode._normalizedIdentifier | |||
| } | |||
| if let script = script { | |||
| if let script = script, script != "" { | |||
There was a problem hiding this comment.
I think we might prefer !script.isEmpty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some examples:
Fix this by handling empty identifiers passed in at initialization time correctly.
resolves 132353443