URL.absoluteString crashes if baseURL starts with colon #1119
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS Platform |
3 similar comments
|
@swift-ci please test macOS Platform |
|
@swift-ci please test macOS Platform |
|
@swift-ci please test macOS Platform |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent regression from reverting to compatibility
URLbehaviors in #1113.URL.absoluteStringusesURLComponentsto build the string from the correct parts of the relative and base URLs. After allowingURLto have an empty scheme for compatibility in #1113,URL.absoluteStringwould crash if we used an empty scheme from the base URL. The crash occurs when we assigncomponents.scheme = ""sinceURLComponentsdoes not consider an empty scheme valid.Since we are only using
URLComponentsto produce an absolute string, we can bypass the scheme validation with an internal function, since the scheme used for the URL'sabsoluteStringhas already been validated by the baseURL.