Fix _copyDirectoryMetadata
compilation error on FreeBSD
#1121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_copyDirectoryMetadata
does not compile on FreeBSD sincef{list,get}xattr
is not available. Useextattr_*_fd
to copy extended attributes recursively instead.Unlike the Linux variant,
extxattr_*(2)
does not return an entry list with null terminating attribute names. Instead, each list entry consists of a single byte containing the length of the attribute name follow by the non-null terminating name itself.To iterate each entry:
extattr_{get, set}_fd
. Finally we set thecurrent
pointer to the next attribute name.Apart from the difference in how the entry list is iterated, unlike Linux, the extended attributes namespaces are not determined by the prefix the attribute names. Instead, we need to iterator each namespace (
EXTATTR_NAMESPACE_SYSTEM
,EXTATTR_NAMESPACE_USER
) separately.