[5.7][PkgConfig] Avoid creating dummy dependency #5749
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be seen in some awkwardly generated .pc files and it can crash SwiftPM silently at least on Windows.
stevapple
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
neonichu
approved these changes
Aug 26, 2022
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #5741
Dummy dependency can be seen in some awkwardly generated
.pcfiles and it can crash SwiftPM silently at least on Windows.Motivation:
To enhance robustness and avoid silent crashes on Windows.
Modifications:
Ignore parsed dependency with an empty name from a
.pcfile.Result:
SwiftPM will not crash when parsing dependency list like
dep1, , dep2.