Adopt swift-toolchain-sqlite to reduce system dependencies
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we no longer require users to provide their own system SQLite installation on Linux or Windows.
|
@swift-ci test |
MaxDesiatov
added a commit
that referenced
this pull request
Aug 27, 2024
Verified manually that `swift-sdk-generator` itself can be cross-compiled when using #127.
|
Suppose this is a question for @jakepetroules - should swift-toolchain-sqlite use the system dependency for Apple platforms, or is it intentional that all platforms are just using the amalgamation? |
MaxDesiatov
added a commit
that referenced
this pull request
Aug 28, 2024
Verified manually that `swift-sdk-generator` itself can be cross-compiled when using #127.
|
@swift-ci test |
|
FWIW without this change due to SwiftPM's bug in |
|
@swift-ci test |
…/swift-toolchain-sqlite # Conflicts: # Package.swift
|
@swift-ci test |
|
Are you going to merge this? Just curious, as it seems like it could be a good improvement. |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we no longer require users to provide their own system SQLite installation on Linux or Windows.