Skip to content

Commit

Permalink
[android][build-script] Update the default arch to AArch64, as that i…
Browse files Browse the repository at this point in the history
…s by far the most commonly used now
  • Loading branch information
finagolfin committed Jul 20, 2024
1 parent fb7bb19 commit 6ede1c2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion utils/build_swift/build_swift/driver_arguments.py
Original file line number Diff line number Diff line change
Expand Up @@ -1393,7 +1393,7 @@ def create_argument_parser():

option('--android-arch', store,
choices=['armv7', 'aarch64', 'x86_64'],
default='armv7',
default='aarch64',
help='The target architecture when building for Android. '
'Currently, only armv7, aarch64, and x86_64 are supported. '
'%(default)s is the default.')
Expand Down
4 changes: 2 additions & 2 deletions utils/build_swift/tests/expected_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
'android_api_level': '21',
'android_deploy_device_path': '/data/local/tmp',
'android_ndk': None,
'android_arch': 'armv7',
'android_arch': 'aarch64',
'assertions': True,
'benchmark': False,
'benchmark_num_o_iterations': 3,
Expand Down Expand Up @@ -764,7 +764,7 @@ class BuildScriptImplOption(_BaseOption):
ChoicesOption('--swift-analyze-code-coverage',
choices=['false', 'not-merged', 'merged']),
ChoicesOption('--android-arch',
choices=['armv7', 'aarch64']),
choices=['armv7', 'aarch64', 'x86_64']),

StrOption('--android-api-level'),
StrOption('--build-args'),
Expand Down

0 comments on commit 6ede1c2

Please sign in to comment.