Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] change shortname for Android arch definitions #77173

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrurogerz
Copy link
Contributor

@andrurogerz andrurogerz commented Oct 22, 2024

Overview

Change the short name for the Android i686 arch to x86 and the x86_64 arch to x64. These names match the names of the containing variables, $AndroidX86 and $AndroidX64 (variable names are not case sensitive).

Background

Without this change, any build.ps1 build on Windows that includes the x86_64 Android SDK fails with an error like so:

Error: Cannot find a variable with the name 'Androidx86_64'.
    at <ScriptBlock>, S:\SourceCache\swift\utils\build.ps1: line 1873
    at Isolate-EnvVars, S:\SourceCache\swift\utils\build.ps1: line 581
    at Build-Foundation, S:\SourceCache\swift\utils\build.ps1: line 1869
    at Invoke-BuildStep, S:\SourceCache\swift\utils\build.ps1: line 416
    at <ScriptBlock>, S:\SourceCache\swift\utils\build.ps1: line 2791
  From System.Management.Automation.ItemNotFoundException: Cannot find a variable with the name 'Androidx86_64'.

And for the i686 arch:

Error: Cannot find a variable with the name 'Androidi686'.
    at <ScriptBlock>, S:\SourceCache\swift\utils\build.ps1: line 1873
    at Isolate-EnvVars, S:\SourceCache\swift\utils\build.ps1: line 581
    at Build-Foundation, S:\SourceCache\swift\utils\build.ps1: line 1869
    at Invoke-BuildStep, S:\SourceCache\swift\utils\build.ps1: line 416
    at <ScriptBlock>, S:\SourceCache\swift\utils\build.ps1: line 2791
  From System.Management.Automation.ItemNotFoundException: Cannot find a variable with the name 'Androidi686'.

The build succeeds if only aarch64 and/or armv7 are specified, since their short names are already correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant