[AutoDiff] Fix assert on missing struct decl on cross-file derivative search #77183
+79
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @asl |
|
@swift-ci please test |
asl
reviewed
Oct 23, 2024
|
@swift-ci please test |
… search Consider: 1. File struct.swift defining `struct Struct` with `static func max` member 2. File derivatives.swift defining `extension Struct` with custom derivative of the `max` function 3. File error.swift defining a differentiable function which uses `Struct.max`. Previously, when passing error.swift as primary file and derivatives.swift as a secondary file to swift-frontend (and forgetting to pass struct.swift as a secondary file as well), an assertion failure was triggered in the following call stack: ``` assert(type->mayHaveMembers()); // while type is ErrorType TypeChecker::lookupMember findAutoDiffOriginalFunctionDecl typeCheckDerivativeAttr DerivativeAttrOriginalDeclRequest::evaluate ``` This patch fixes the issue by adding a check against `ErrorType` in `findAutoDiffOriginalFunctionDecl` before calling `lookupMember`.
Co-authored-by: Anton Korobeynikov <[email protected]>
kovdan01
force-pushed
the
fix-assert-custom-derivatives
branch
from
0e6a3af
to
bcedb71
Compare
|
@swift-ci please test |
|
@slavapestov @rxwei @hborla @xedin Would be glad to see your feedback on the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider:
struct Structwithstatic func maxmemberextension Structwith custom derivative of themaxfunctionStruct.max.Previously, when passing error.swift as primary file and derivatives.swift as a secondary file to swift-frontend (and forgetting to pass struct.swift as a secondary file as well), an assertion failure was triggered in the following call stack:
This patch fixes the issue by adding a check against
ErrorTypeinfindAutoDiffOriginalFunctionDeclbefore callinglookupMember.