Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update CMake to 3.29.8 #77340

Closed
wants to merge 1 commit into from
Closed

Conversation

bnbarham
Copy link
Contributor

3.29 has many fixes for Swift support, the most notable being that it now adds compile jobs separate to the link job. This has a huge benefit for the swift-foundation toolchain install, which can now just re-link rather than rebuild.

3.29 has many fixes for Swift support, the most notable being that it now adds
compile jobs separate to the link job. This has a huge benefit for the
swift-foundation toolchain install, which can now just re-link rather
than rebuild.
@bnbarham bnbarham requested a review from etcwilde October 31, 2024 23:50
@bnbarham bnbarham requested a review from shahmishal as a code owner October 31, 2024 23:50
@bnbarham
Copy link
Contributor Author

swiftlang/swift-testing#792

@swift-ci please test

@finagolfin
Copy link
Member

Note that I saw a problem when trying to use the latest 3.30 release to cross-compile the Swift toolchain, so that will need to be fixed before this version can be advanced even further.

@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 1, 2024

swiftlang/swift-testing#792

@swift-ci please test Windows platform

@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 1, 2024

Note that swiftlang/swift-foundation#878 (comment), so that will need to be fixed before this version can be advanced even further.

Interesting, good to know, thanks. CC @etcwilde

@bnbarham
Copy link
Contributor Author

bnbarham commented Nov 1, 2024

swiftlang/swift-testing#792

@swift-ci please test macOS platform

Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahmishal
Copy link
Member

Going to try bumping the CMake version 3.30.2 - #77465

@shahmishal shahmishal closed this Nov 9, 2024
@bnbarham bnbarham deleted the new-cmake branch November 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants