Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1][Runtime] Add ccAttrs to slow path in compatibility overrides #79595

Open
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Open

[6.1][Runtime] Add ccAttrs to slow path in compatibility overrides #79595

wants to merge 1 commit into from
+4 −3

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Feb 25, 2025

  • Explanation: The ccArgs were accidentally dropped when introducing the slow path, which causes CC mismatches for functions using custom CC.
  • Scope: Compatibility Overrides
  • Issues: rdar://145523626
  • Original PRs: [Runtime] Add ccAttrs to slow path in compatibility overrides #79594
  • Risk: Low. The change only matches the CC between fast and slow path.
  • Testing: Examined the resulting asm to ensure the correct behavior.
  • Reviewers: @mikeash

@drexin
[Runtime] Add ccAttrs to slow path in compatibility overrides
7430c53 
rdar://145523626

This was accidentally dropped when introducing the slow path, which causes CC mismatches for functions
using custom CC.
@drexin drexin added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.1-dev labels Feb 25, 2025
@drexin drexin requested a review from a team as a code owner February 25, 2025 01:38
@drexin
Copy link
Contributor Author

drexin commented Feb 25, 2025

@swift-ci test

DougGregor
DougGregor approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.1-dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drexin @DougGregor