feat(components): post-header #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the post-header component in a preview state. Some of the functionality is already in place and can be used for testing. The intention is, that this component is already available when building the other components for the header to make integration easier to test.
This allows to call the media mixins with keys from the breakpoint list directly, e.g. `@include media.max(lg) { }`.
🦋 Changeset detectedLatest commit: 972e41e The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
alizedebray
requested changes
Oct 30, 2024
packages/components/src/index.html
Outdated
There was a problem hiding this comment.
Please reset changes in this file.
There was a problem hiding this comment.
Can we keep it to document the required markup until it's in storybook?
| // in Safari and Chrome because the header and the footer are yellow, the yellow surface stretches | ||
| // beyond the body. If this is not yellow, overscrolling reveals a white background and the header | ||
| // suddenly seems in the middle of the page. | ||
| background-color: color.$yellow; |
There was a problem hiding this comment.
Nice! Do we want this to be yellow for Cargo too?
| /** | ||
| Gets a breakpoint from the map based on the key | ||
| */ | ||
| @function get-device-size($size) { |
There was a problem hiding this comment.
Can you move this function to the "functions" folder?
Comment on lines
16
to
17
| private throttledScroll = () => this.handleScrollEvent(); | ||
| private debouncedResize = throttle(50, () => this.handleResize()); |
There was a problem hiding this comment.
There seem to be a mismatch with the throttled/debounced naming.
alizedebray
approved these changes
Nov 11, 2024
Added prototypes for the main navigation and the megadropdown for structure testing. Styles, tests and documentation is still missing. --------- Co-authored-by: Alizé Debray <[email protected]>
|
gfellerph
pushed a commit
that referenced
this pull request
Nov 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @swisspost/[email protected] ### Major Changes - Removed the deprecated `.pi-*` classes, which were previously used to display icons. The `post-icon` component should now be used instead. (by [@alizedebray](https://github.com/alizedebray) with [#3947](#3947)) ### Minor Changes - Added custom styles for the ordered lists. (by [@veyaromain](https://github.com/veyaromain) with [#3755](#3755)) ### Patch Changes - Fixed issue where the focus ring was not appearing on inactive chips. (by [@schaertim](https://github.com/schaertim) with [#3820](#3820)) ## @swisspost/[email protected] ### Minor Changes - Added a provisional post-header component with some basic functionality in place. This component is not finished in this state. (by [@gfellerph](https://github.com/gfellerph) with [#3837](#3837)) - Added new Menu Button components (post-menu-button, post-menu-trigger, and post-menu-item) for creating accessible dropdown menus. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#3795](#3795)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added a provisional post-header component with some basic functionality in place. This component is not finished in this state. (by [@gfellerph](https://github.com/gfellerph) with [#3837](#3837)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added a provisional post-header component with some basic functionality in place. This component is not finished in this state. (by [@gfellerph](https://github.com/gfellerph) with [#3837](#3837)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added new Menu Button components (post-menu-button, post-menu-trigger, and post-menu-item) for creating accessible dropdown menus. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#3795](#3795)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a provisional post-header component with some basic functionality in place. This component is not finished in this state and is intended to provide a skeleton for the other header components so integration is easier to test.