Bugfix: Prevent replacing string occurences of extension in filename #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Any filenames with the extension in it are being stripped out from this line:
Aqua-Resizer/aq_resizer.php
Line 128 in 57fe7e7
And thus, fails this check here:
Aqua-Resizer/aq_resizer.php
Line 136 in 57fe7e7
E.g.
/2019/01/filename.jpg-hello.jpg-test-name.jpg
, where all occurrences ofjpg
become stripped out when only the actual extension at the end of it should be. This patch looks for the last occurrence of the extension at the end and strips it out by position instead.