Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/shoestring]: add support for advanced customization of rest.json #1091

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

Jaguar0625
Copy link
Contributor

 problem: shoestring only allows user to specify nodeMetadata property of rest.config
solution: allow user to provide differential config file that overrides defaults (similar to REST native support)

   issue: #1090

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (c8d3ad8) to head (cc6270b).
Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1091   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         162      162           
  Lines        6618     6623    +5     
  Branches      143      143           
=======================================
+ Hits         6502     6507    +5     
  Misses        116      116           
Flag Coverage Δ
explorer-nodewatch 98.40% <ø> (ø)
explorer-rest 99.25% <ø> (ø)
faucet-authenticator 100.00% <ø> (ø)
faucet-backend 98.91% <ø> (ø)
faucet-frontend 100.00% <ø> (ø)
lightapi-python 98.35% <ø> (ø)
tools-shoestring 96.86% <100.00%> (+<0.01%) ⬆️
tools-vanity 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/shoestring/shoestring/commands/setup.py 100.00% <100.00%> (ø)
...string/shoestring/internal/ConfigurationManager.py 100.00% <100.00%> (ø)
tools/shoestring/shoestring/internal/Preparer.py 100.00% <100.00%> (ø)
...hoestring/shoestring/wizard/ShoestringOperation.py 100.00% <100.00%> (ø)
...oestring/shoestring/wizard/setup_file_generator.py 100.00% <100.00%> (ø)
...estring/shoestring/wizard/shoestring_dispatcher.py 100.00% <100.00%> (ø)

Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

 problem: this file is useful locally but should not be committed
 problem: shoestring only allows user to specify nodeMetadata property of rest.config
solution: allow user to provide differential config file that overrides defaults (similar to REST native support)

   issue: #1090
@Jaguar0625 Jaguar0625 merged commit cc6270b into dev Sep 7, 2024
16 checks passed
@Jaguar0625 Jaguar0625 deleted the shoestring/rest_overrides branch September 7, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants