Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fix: broken links #764

Merged
merged 3 commits into from
Apr 14, 2022
Merged

[docs] fix: broken links #764

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2de454f
[docs] fix: broken links
Wayonb Mar 25, 2022
5b281c1
[docs] fix: more broken links
Wayonb Apr 12, 2022
e13e7e7
[docs] fix: address feedback
Wayonb Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,9 @@ def setup(app):
r'https://arxiv.org/.*', # Sometimes returns 403 on Travis (rate limit?)
r'https://www.researchgate.net/.*', # Started returning 403 on Travis
r'https://symbolblog.com/.*', # Returning 403
r'https://docs.github.com/.*', # GitHub is now returning 403
r'https://help.github.com/.*', # GitHub is now returning 403
r'https://github.com/fboucquez/symbol-bootstrap#command-topics', # Returning Anchor 'command-topics' not found
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really prefer that we do not overpopulate this list... this is weakening the link check :/
I think the right anchor in this case is:
https://github.com/fboucquez/symbol-bootstrap#user-content-command-topics

Also, all these 403 might be related to throttling? The link checker has a mechanism to avoid making too many consecutive requests to the same server, but maybe changing the CI has altered that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xavi, I think I found the issue with 403 error. If I add with user_agent it seems to fix the problem

sphinx-doc/sphinx#7369 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated link for bootstrap also fix the issue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

]
linkcheck_anchors_ignore = [r'L\d+']

Expand Down
2 changes: 1 addition & 1 deletion source/guides/network/using-symbol-bootstrap.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ You need to own the domain ``awesomenode.mycompany.net`` and it needs to resolve
Next steps
**********

- Read the `complete list <https://github.com/fboucquez/symbol-bootstrap/blob/main/README.md>`_ of ``symbol-bootstrap`` commands.
- Read the `complete list <https://github.com/fboucquez/symbol-bootstrap#command-topics>`_ of ``symbol-bootstrap`` commands.

- Go ahead and create a node following the :doc:`running-a-symbol-node` guide.