Feature/use gb full #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sync with master, the CI should now be fixed and the failing IE test marked as a known failure. |
|
Thank you for your review! I tried to address your comments. Let me know what you think :) |
rth
reviewed
Nov 28, 2019
| self._data_path, self._data = self._get_data(country) | ||
| country_obj = _Country(country) | ||
| self.country = country_obj.name | ||
| self.download_path = country_obj.get_download_path() |
There was a problem hiding this comment.
Let's make this private as well,
Suggested change
| self.download_path = country_obj.get_download_path() | |
| self._download_path = country_obj.get_download_path() |
| @@ -26,6 +26,11 @@ def temp_dir(): | |||
| shutil.rmtree(path) | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope='session') | |||
| def country_gb_full(): | |||
| return pgeocode._Country('gb_full') | |||
There was a problem hiding this comment.
Typically session level fixtures are used for expensive operation (e.g. loading the data, or file access operations) once per session run.
To test _Country we should rather initialize it in each test that needs (and not use fixture).
|
|
||
|
|
||
| def test_that_get_clean_country_raises_value_error(): | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Suggested change
| with pytest.raises(ValueError): | |
| with pytest.raises(ValueError, match="not a known country code"): |
|
Hi guys! Is it possible to merge this fix? It would still be great to have the possibility to use GB_full database instead GB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Countries.