Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albanian translation #1489

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Albanian translation #1489

merged 1 commit into from
Feb 8, 2024

Conversation

llupa
Copy link
Contributor

@llupa llupa commented Feb 1, 2024

Albanian XLIFF language files added, and config.yml updated.

@llupa
Copy link
Contributor Author

llupa commented Feb 1, 2024

Note: This is very fresh. I opened the PR in Draft so I can re-read it in the next days.

  • I have checked and adapted language so it is also not breaking UI elements.
  • Language used is in informal tone like it is in ita since formal Albanian gives a fake vibe (for the nature of this app).
    • I can reverse to fully formal or fully formal & legalese.

Tools used:

PS. I am Albanian

@llupa llupa force-pushed the main branch 2 times, most recently from 28b4611 to 4b7d438 Compare February 5, 2024 18:20
@llupa llupa marked this pull request as ready for review February 5, 2024 18:23
@llupa
Copy link
Contributor Author

llupa commented Feb 7, 2024

waiting for possible convention acceptance at symfony/symfony#53797

@javiereguiluz
Copy link
Member

I see that the linked PR was merged. Does that mean that this PR is also mergeable? Thanks

@llupa
Copy link
Contributor Author

llupa commented Feb 7, 2024

I will update tonight with the same conventions and add the translator notes!

@llupa
Copy link
Contributor Author

llupa commented Feb 8, 2024

@javiereguiluz este PR esta listo

@javiereguiluz
Copy link
Member

This is now merged!

@llupa what a great contribution you did here! Your meticulous work to make sure that the translation was as good as possible is truly inspiring. We're fortunate to have you in our community.

@javiereguiluz javiereguiluz merged commit e6f2352 into symfony:main Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants