Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove importmap:install command from devcontainer.json #1544

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

maxgrundnig
Copy link
Contributor

@maxgrundnig maxgrundnig commented Dec 8, 2024

If it is executed as part of the updateContentCommand step, the container creation fails.

importmap:install is executed by composer install though (part of the auto-scripts), which executes just fine in Codespaces.

Part of #1542

If it is executed as part of the updateContentCommand step, the container creation fails.

importmap:install is executed by composer install though (part of the auto-scripts), which executes just fine in Codespaces.

Fixes symfony#1542

Co-authored-by: Wolfgang Weintritt <[email protected]>
@maxgrundnig maxgrundnig mentioned this pull request Dec 9, 2024
11 tasks
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot.

@javiereguiluz
Copy link
Member

Thanks for fixing this bug Max.

@javiereguiluz javiereguiluz merged commit b42567d into symfony:main Dec 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants