[TogglePassword] Add example page for ux.symfony.com #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Aug 7, 2023
| {% block code_block_right %} | ||
| <twig:CodeBlock | ||
| filename="templates/ux_packages/toggle_password.html.twig" | ||
| targetTwigBlock="demo_content" |
There was a problem hiding this comment.
Too much indentation on these 2 lines
| {{ form_start(form) }} | ||
| {{ form_row(form.email) }} | ||
| {{ form_row(form.password) }} | ||
| <button type="submit" class="btn btn-primary">Login</button> |
There was a problem hiding this comment.
I usually indent the form_row and button - as if form_start() was actually a <form> tag. Subjective though
There was a problem hiding this comment.
I had a discussion with @HeahDude about this (he shares your opinion) and i agree with both of you, i like the logic 👍🏼
weaverryan
force-pushed
the
add/ux-symfony-page
branch
from
c3eefa6
to
18e49a9
Compare
|
Thanks Félix! I'll deploy this when we push out the next version it's been a pleasure reviewing your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the new TogglePassword component to ux.symfony.com with a minimalist example of what to expect "out of the box" 😄 (using default theme without any customization)
Previews
Homepage card
TogglePassword page
