Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Support page #2091

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[Site] Support page #2091

merged 1 commit into from
Aug 22, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Aug 21, 2024

Minimal / simple page to list support options

Capture d’écran 2024-08-22 à 06 23 30

You had @WebMamba something like this in mind ?

@carsonbot carsonbot added Site ux.symfony.com Status: Needs Review Needs to be reviewed labels Aug 21, 2024
@smnandre smnandre marked this pull request as draft August 21, 2024 23:08
@smnandre smnandre requested review from WebMamba, kbond and Kocal August 22, 2024 14:43
@kbond
Copy link
Member

kbond commented Aug 22, 2024

I like this!

@Kocal
Copy link
Member

Kocal commented Aug 22, 2024

What about the logo to the left of the title?

@smnandre
Copy link
Member Author

What about the logo to the left of the title?

Two reasons i kept it top of the title

  • i wanted to change a bit from the "PackageBox", have some variety in card layouts
  • i have something in mind for the top right space but i'd like to see if the page is used, first :)

But no problem if you prefer, i don't really mind here :))

@kbond
Copy link
Member

kbond commented Aug 22, 2024

Make sense. Let's roll with this!

@Kocal
Copy link
Member

Kocal commented Aug 22, 2024

What about the logo to the left of the title?

Two reasons i kept it top of the title

  • i wanted to change a bit from the "PackageBox", have some variety in card layouts
  • i have something in mind for the top right space but i'd like to see if the page is used, first :)

But no problem if you prefer, i don't really mind here :))

Okay, let's keep it that way then :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 22, 2024
@smnandre smnandre marked this pull request as ready for review August 22, 2024 21:18
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Aug 22, 2024
@smnandre
Copy link
Member Author

Capture d’écran 2024-08-22 à 23 17 03

@smnandre smnandre requested a review from Kocal August 22, 2024 21:20
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in light/dark modes, and in mobile too:
Capture d’écran 2024-08-23 à 00 34 12
image
image

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 22, 2024
@Kocal Kocal force-pushed the site/support-page branch from f818828 to 5e25b4c Compare August 22, 2024 22:35
@Kocal
Copy link
Member

Kocal commented Aug 22, 2024

Thank you @smnandre.

@Kocal Kocal merged commit a9271c1 into symfony:2.x Aug 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants