Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbo][Testing] Fix to the right test #2234

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[Turbo][Testing] Fix to the right test #2234

merged 1 commit into from
Oct 21, 2024

Conversation

GrinWay
Copy link
Contributor

@GrinWay GrinWay commented Oct 4, 2024

Q A
Bug fix? no
New feature? no
Issues Fixing the test
License MIT

In order to test the Turbo loading you don't have to use assertSelectorTextContains method, instead of it use assertSelectorWillContain cuz it's async javascript

@carsonbot carsonbot added Turbo Status: Needs Review Needs to be reviewed labels Oct 4, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 4, 2024
@smnandre
Copy link
Member

smnandre commented Oct 5, 2024

Well maybe we should change the preceding paragraph then, because this method is not shared with the DomCrawler api :\

@kbond
Copy link
Member

kbond commented Oct 21, 2024

Good catch, thanks @GrinWay.

@kbond kbond merged commit 02737a4 into symfony:2.x Oct 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer Turbo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GrinWay @smnandre @kbond @nicolas-grekas @carsonbot