Direct Start Workload #416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Rash <[email protected]>
Signed-off-by: Jordan Rash <[email protected]>
autodidaddict
requested changes
Nov 1, 2024
Signed-off-by: Jordan Rash <[email protected]>
Signed-off-by: Jordan Rash <[email protected]>
Signed-off-by: Jordan Rash <[email protected]>
autodidaddict
requested changes
Nov 1, 2024
Signed-off-by: Jordan Rash <[email protected]>
autodidaddict
approved these changes
Nov 1, 2024
| @@ -24,24 +28,57 @@ type ArtifactReference struct { | |||
| Size int | |||
| } | |||
|
|
|||
| func extractTag(location *url.URL) string { | |||
| return location.Fragment | |||
There was a problem hiding this comment.
What happened to the code that checks for a :, splits, and returns the tag and if none exists it returns "latest"?
| // TODO: Implement | ||
| return nil, nil | ||
| filePath, tag := "", "" | ||
| sPath := strings.SplitN(location.Path, ":", 2) // splits on first : only |
There was a problem hiding this comment.
Should this call extract tag?
| } | ||
| } | ||
|
|
||
| // waits 5 seconds for workload to shutdown gracefully |
There was a problem hiding this comment.
It pains me to see a timed retry loop appear here. We should eventually figure out a better way:tm:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.