-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add channel close feature #382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
approved these changes
Nov 15, 2023
ashuralyk
force-pushed
the
feat/channel-close
branch
from
November 15, 2023 12:34
35d986f
to
1f26e14
Compare
@blckngm this PR's CI won't pass because we give relayer a random key but the module is set |
ashuralyk
force-pushed
the
feat/channel-close
branch
from
November 17, 2023 02:11
a142a10
to
0a52c56
Compare
ashuralyk
force-pushed
the
feat/channel-close
branch
from
November 17, 2023 02:24
0a52c56
to
129b9af
Compare
@Flouse this PR can start to review |
jjyr
approved these changes
Nov 21, 2023
Flouse
reviewed
Nov 21, 2023
Flouse
reviewed
Nov 22, 2023
Flouse
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
Channel layer misses close feature for a long time, and for a compatible version of IBC protocol,
close feature
should be accomplished at last.Change logs
query_txs()
method, but others are unreachable to doRelated PRs