Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Detect
v8
and addresses issue #45.We have renamed the interfaces in order to match the same naming as bladuck-common-api 2022.10.4.
We also added the new interfaces for this action to work with Detect
v8
.The logic itself for generating the report has minimal changes and was adapted to use the new matching fields for the new interfaces required for
v8
.Note:
This code has breaking changes and will only be compatible with detect from
v8
onwards. Meaning that all versions below are not compatible with these changes.We have decided to not include backward compatibility on the code to avoid dealing with different versions and have more complex code without need. People using this action can always use tag
v0.3.4
, to get proper working scans for detect versions up tov7
.Assuming that you are following SemVer and are using major version
0
meaning that this is still under development, and everything can change, a major bump on version would not be needed. But since this breaks compatibility with older Detect versions belowv8
, I think we should add a note somewhere regarding this.If you need something, please reach out.
Thanks for this project 💚