Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and Modularize Features #12

Merged
merged 16 commits into from
Nov 20, 2024
Merged

Refactor and Modularize Features #12

merged 16 commits into from
Nov 20, 2024

Conversation

adelhpour
Copy link
Member

Pull Request Description

Overview:
This PR refactors the codebase by extracting several functionalities as features and standardizing function names for better clarity and organization.

Changes:

  1. Feature Extraction:

    • Functions for layout features, update curves, fixing positions, aligning elements, hiding elements, creating alias elements, handling SBML objects user data, and logging errors have been modularized.

  2. Directory Restructure:

    • autolayout, colors, and styles directories moved under the features directory.

@adelhpour
Logging the error is extracted as a feature
15734d0
@adelhpour
Handling SBML objects userdata is extracted as a feature
3be3573
@adelhpour
Layout and Render default values are extracted as a feature
d3e0350
@adelhpour
error log function names that used to be prefixed with 'el' are now p…
8452caa 
…refixed with 'error_log'
@adelhpour
user data function names that used to be prefixed with 'ud' are now p…
ff7709e 
…refixed with 'user_data'
@adelhpour
creating alias elements is extracted as a feature
89458b8
@adelhpour
'styles' directory is moved under the 'features' directory
f6c65c0
@adelhpour
'colors' directory is moved under the 'features' directory
3599e3e
@adelhpour
'autolayout' directory is moved under the 'features' directory
ad8d83e
@adelhpour
hiding elements is extracted as a feature
e2c4265
@adelhpour
aligning elements is extracted as a feature
72192b6
@adelhpour
fixing elements position and dimensions is extracted as a feature
b290301 
- 'lock' term is replaced with 'fix position' throughout the code base
@adelhpour
set layout features and update curves are extracted as features
c371fe5
@adelhpour
functions in the autolayout feature are prefixed with 'autolayout_'
bcda332
@adelhpour
fix the issue with including the headers and defining 'M_PI'
748e63a
@adelhpour
update cmake script to install the header files properly
6548df1
@adelhpour adelhpour merged commit 6cfb63e into develop Nov 20, 2024
10 checks passed
@adelhpour adelhpour deleted the extract-features branch November 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adelhpour