specify columns on insert to be more robust regarding schema changes

syseleven · Feb 1, 2022 · 50b7e0e · 50b7e0e
1 parent 2e26969
commit 50b7e0e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.30b1 (2022-02-01)
+
+* specify columns on insert to be more robust regarding schema changes (thanks to @jonico)
+
 # 0.30b0 (2021-12-29)
 
 * increased PBKDF2 iteration count for v00 encryption from 10000 to 512000

diff --git a/index.php b/index.php
@@ -1,8 +1,8 @@
 <?php
 
-  # Shared-Secrets v0.30b0
+  # Shared-Secrets v0.30b1
   #
-  # Copyright (c) 2016-2021, SysEleven GmbH
+  # Copyright (c) 2016-2022, SysEleven GmbH
   # All rights reserved.
   #
   # This page allows you to share a secret through a secret sharing link.

diff --git a/lib/shared-secrets.def.php b/lib/shared-secrets.def.php
@@ -13,7 +13,7 @@
 
   # define MySQL queries
   define("MYSQL_READ",  "SELECT COUNT(*) FROM secrets WHERE fingerprint = ?");
-  define("MYSQL_WRITE", "INSERT IGNORE INTO secrets VALUES (?, ?, CURRENT_TIMESTAMP)");
+  define("MYSQL_WRITE", "INSERT IGNORE INTO secrets (keyid, fingerprint, time) VALUES (?, ?, CURRENT_TIMESTAMP)");
 
   # define page names
   define("HOW_PAGE_NAME",     "how");