Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #47

Open
xPaw opened this issue Dec 6, 2019 · 5 comments
Open

Upgrade dependencies #47

xPaw opened this issue Dec 6, 2019 · 5 comments

Comments

@xPaw
Copy link

xPaw commented Dec 6, 2019

We get following warnings in our project:

warning mochapack > babel-runtime > [email protected]: core-js@<3.0 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning mochapack > chokidar > [email protected]: One of your dependencies needs to upgrade to fsevents v2: 1) Proper nodejs v10+ support 2) No more fetching binaries from AWS, smaller package size
@larixer
Copy link
Member

larixer commented Dec 8, 2019

Yeah, it would be great to upgrade these dependencies, though it might be not a very easy journey. Babel 6 -> Babel 7 upgrade is needed, it should be generally straightforward. But I'm not sure that all the latest deps (for example watchpack) can actually use the latest fsevents version. And I'm not also sure if multiple chokidar/fsevents versions can coexist peacefully, I saw at least once the multiple chokidar versions do not work well together:
#39

@xPaw
Copy link
Author

xPaw commented Dec 8, 2019

Have you considered just using native fs.watch?

Looking at watchpack, they removed chokidar in v2 beta releases: webpack/watchpack@805b665#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

@larixer
Copy link
Member

larixer commented Dec 9, 2019

@xPaw Well, chokidar also uses native fs.watch:
https://github.com/paulmillr/chokidar#how
It just wraps it. And watchpack has also non-trivial wrapping code around native fs.watch. I am basically okay with either option: native fs.watch or library around native fs.watch.

@xPaw
Copy link
Author

xPaw commented Dec 9, 2019

Well, chokidar comes with the baggage of fsevents, which has a native package (and all of its problems)

@specialistvlad
Copy link

specialistvlad commented Apr 11, 2020

Please update chokidar v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants