-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Flow and Babel dependencies #49
Conversation
Taking another look at this on a PC at work - everything was passing on my Mac at home - might be the Node version I was using ( |
Attempting a change in the test fixture - passes on my WSL under |
🤷🏻♂️ No idea what's going on here. I think it's probably a race condition somewhere given that it's passing in all environments except Node 10 with Doesn't make much sense that it would pass in Node 10 on Mocha |
@Jack-Barry These |
I'm brave but not feeling that brave right now 😐 haha. Reworked the file to use |
@Jack-Barry Very nice, thank you! |
Cool, looks great, many thanks! |
What's the problem this PR addresses?
I forget where I saw it, but remember reading that a shift over to TypeScript from Flow would be welcome here. I decided to go ahead and upgrade Babel so that the transition will be more feasible.
How did you fix it?
Upgraded dependencies and fixed any places that the upgrades broke tests.