Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flow and Babel dependencies #49

Merged
merged 5 commits into from
Dec 12, 2019
Merged

Upgrade Flow and Babel dependencies #49

merged 5 commits into from
Dec 12, 2019

Conversation

Jack-Barry
Copy link

What's the problem this PR addresses?

I forget where I saw it, but remember reading that a shift over to TypeScript from Flow would be welcome here. I decided to go ahead and upgrade Babel so that the transition will be more feasible.

  • This fixes at least part of Upgrade dependencies #47 by upgrading Babel dependencies
  • This upgrades the Flow dependency so that plugin for VS Code can be used until the shift over to TypeScript is complete

How did you fix it?

Upgraded dependencies and fixed any places that the upgrades broke tests.

@Jack-Barry
Copy link
Author

Jack-Barry commented Dec 11, 2019

Taking another look at this on a PC at work - everything was passing on my Mac at home - might be the Node version I was using (12.13.1, will try it again in 10.17.0 and 8.16.2).

@Jack-Barry
Copy link
Author

Jack-Barry commented Dec 11, 2019

Attempting a change in the test fixture - passes on my WSL under 10.17.0, but the erroring test is skipped on Windows OS.

@Jack-Barry
Copy link
Author

🤷🏻‍♂️ No idea what's going on here. I think it's probably a race condition somewhere given that it's passing in all environments except Node 10 with WEBPACK_VERSION=4 MOCHA_VERSION=5.

Doesn't make much sense that it would pass in Node 10 on Mocha 4 and 6 but not 5 since it's in between those so any breaking changes would be affecting 6. Maybe the timeout on those failing specs needs to be bumped up a bit to 30000?

@Klitsenko
Copy link

Klitsenko commented Dec 11, 2019

@Jack-Barry These cli --watch tests are unreliable (they fail for me all the time since I forked mocha-webpack), I'm not sure why are them there indeed. I'm fine with disabling them for now. If you are brave you can figure out how to make them more reliable.

@Jack-Barry
Copy link
Author

I'm brave but not feeling that brave right now 😐 haha. Reworked the file to use xdescribe instead of commenting out specs so that at least the tests are visible as skipped when being run.

@Jack-Barry Jack-Barry mentioned this pull request Dec 12, 2019
@Klitsenko
Copy link

@Jack-Barry Very nice, thank you!

@larixer
Copy link
Member

larixer commented Dec 12, 2019

Cool, looks great, many thanks!

@larixer larixer merged commit 387c9ee into sysgears:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants