Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Switch to PortAudio #76

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Cuda-Chen
Copy link
Contributor

@Cuda-Chen Cuda-Chen commented Feb 23, 2025

Switch to PortAudio for cross-platform and cross backend compatibility.

Yet, there are two known limitations for current sound playback implementation:

  1. The last period of sound is lost.
  2. You cannot play sound twice or the device will crash thus
    whole system crashes.

@jserv
Copy link
Collaborator

jserv commented Feb 23, 2025

You should explain the motivation and benefit for the migration of PortAudio.

@Cuda-Chen Cuda-Chen force-pushed the switch-to-portaudio branch 3 times, most recently from fd58de0 to 0d81990 Compare February 23, 2025 04:39
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

4 similar comments
Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Switch to PortAudio for cross-platform and cross backend compatibility.

Yet, there are two known limitations for current sound playback implementation:
1. The last period of sound is lost.
2. You cannot play sound twice or the device will crash thus
whole system crashes.
@jserv
Copy link
Collaborator

jserv commented Feb 24, 2025

Build failure:

  LD	semu
/usr/bin/ld: cannot find -lpulse: No such file or directory
collect2: error: ld returned 1 exit status

@sysprog21 sysprog21 deleted a comment from bito-code-review bot Feb 24, 2025
@sysprog21 sysprog21 deleted a comment from bito-code-review bot Feb 24, 2025
@sysprog21 sysprog21 deleted a comment from bito-code-review bot Feb 24, 2025
@sysprog21 sysprog21 deleted a comment from bito-code-review bot Feb 24, 2025
@sysprog21 sysprog21 deleted a comment from bito-code-review bot Feb 24, 2025
@sysprog21 sysprog21 deleted a comment from bito-code-review bot Feb 24, 2025
@Cuda-Chen
Copy link
Contributor Author

Build failure:

  LD	semu
/usr/bin/ld: cannot find -lpulse: No such file or directory
collect2: error: ld returned 1 exit status

Thanks for the reminder!
I am still working on this issue.

Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants