Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on adding the advanced luks article to the password article #1166

Merged
merged 11 commits into from
Dec 14, 2023

Conversation

ahoneybun
Copy link
Member

This combines them fixing issue #1161

@ahoneybun ahoneybun marked this pull request as ready for review September 15, 2023 19:41
@ahoneybun ahoneybun requested review from a team September 19, 2023 19:54
updates to the LUKS commands.
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and back to Aaron to make sure he likes my edits.

Copy link
Member Author

@ahoneybun ahoneybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using "pass-phrase" instead of just "passphrase"?

@@ -114,7 +114,7 @@ The output may be different based on the drive setup and partition table. You ca
sudo cryptsetup luksDump /dev/sda3
```

Replacing '/dev/sda3' with the location of the root partition on your system. With the output of this command we can see the seven extra slots that we have for passwords to decrypt the drive. Slots 1-7 are the open ones and Slot 0 is the current one the system has set.
Replacing '/dev/sda3' with the location of the root partition on your system. With the output of this command we can see the seven extra slots that we have for passwords to decrypt the drive. On a normal install Slots 1-7 are the open, with Slot 0 as the initial pass-phrase.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit odd:

On a normal install Slots 1-7 are the open, with Slot 0 as the initial pass-phrase.

I feel like it would be like this:

On a normal install Slots 1-7 are not used and Slot 0 is used as the initial pass-phrase.

Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this live!

Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several places where we assume that a pop install will be on certain devices/ partitions (nvme0n1p3 or sda3) which could cause issues. An image inline, highlighting the listed partition may help a user. More importantly, if we assume that our user is not technically inclined, parts of the article which haven't been touched cite commands using "sda3" when A) "nvme0n1p3" is probably more common now given how many major manufacturers have moved to default nvme drives, let alone our own nvme-centric offerings, and B) might cause users to hit a wall where they just type commands in character-for-character without understanding them. Admittedly, a support article will never replace someone actively engaging with the instructions... but it might still be worth considering changes to some of that verbiage as we're already looking at updating this article.

(I've yet to review the LUKS portion, but will be doing that next)

content/password.md Outdated Show resolved Hide resolved
content/password.md Outdated Show resolved Hide resolved
content/password.md Outdated Show resolved Hide resolved
content/password.md Show resolved Hide resolved
content/password.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this change out to the world

@thomas-zimmerman thomas-zimmerman merged commit 96858d5 into master Dec 14, 2023
3 checks passed
@thomas-zimmerman thomas-zimmerman deleted the update-passwords branch December 14, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants