Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap backplane with board to match production and build #227

Closed
wants to merge 1 commit into from

Conversation

ahoneybun
Copy link
Member

This PR swaps backplane for board to correct name of the component.

@ahoneybun ahoneybun requested review from a team January 3, 2024 16:18
@leviport
Copy link
Member

leviport commented Jan 3, 2024

I believe both terms are correct for that component. What makes you say that "board" is more correct than "backplane"?

@ahoneybun
Copy link
Member Author

I believe both terms are correct for that component. What makes you say that "board" is more correct than "backplane"?

Production says backplane is incorrect and board is correct, like Thelio Io board.

@leviport
Copy link
Member

leviport commented Jan 3, 2024

This README is obviously out of date, but the old Io board was said to "provide a SATA backplane" here: https://github.com/system76/thelio-io-hardware/blob/master/README.md?plain=1#L5

Since this PCB has the SATA functionality broken out into a standalone component, calling this a "SATA backplane" does not seem incorrect to me. Was there another reason for this change?

@ahoneybun
Copy link
Member Author

This README is obviously out of date, but the old Io board was said to "provide a SATA backplane" here: https://github.com/system76/thelio-io-hardware/blob/master/README.md?plain=1#L5

Since this PCB has the SATA functionality broken out into a standalone component, calling this a "SATA backplane" does not seem incorrect to me. Was there another reason for this change?

The only reason is that both Production and Build call it SATA board and when backplane is mentioned they do not know what the part is. This is to get everyone on the same page about the component name.

@ahoneybun ahoneybun closed this Jan 3, 2024
@ahoneybun ahoneybun reopened this Jan 3, 2024
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With respect to the production team, they don't get to unilaterally decide what the products they're building are called.

We are selling this part on the website as a "SATA Backplane":

image

@ahoneybun
Copy link
Member Author

Per @s-mcnees this naming comes from the vendor who makes the product and SATA board is used for ordering the product as well. If there are any other issues with this change please reach out to her.

@jacobgkau
Copy link
Member

this naming comes from the vendor who makes the product

This is our product, we decide the name, not a vendor.

@leviport
Copy link
Member

leviport commented Jan 4, 2024

"Board" is a generic word that describes a PCB, so referring to the component as a board does not mean it's the name of the product. A Lemur Pro is a Lemur Pro, but it is often referred to as a "laptop" or a "computer" or a "machine." Thelio Io is frequently referred to as an "Io board," but that's not its name.

I don't think this change is necessary, and I don't think "SATA backplane" was causing any confusion for readers.

@leviport
Copy link
Member

leviport commented Jan 4, 2024

Per an internal discussion, the official name of the part is SATA Backplane, so I'm going to close this PR.

@leviport leviport closed this Jan 4, 2024
@ahoneybun ahoneybun deleted the swap-backplane-board branch June 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants