lemp13 (external overview): Add placeholder photo of new keyboard #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoneybun
reviewed
May 22, 2024
leviport
approved these changes
May 22, 2024
I don't see why that would be necessary in the context of this photo. They can see which one they're on based on the keyboard layout, which we're providing photos of. If we decide it's necessary to provide more information about the firmware difference later, we can potentially mention a command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This photo's just a placeholder to show the currently shipping keyboard in the lemp13-b. We'll swap it out with the marketing overhead photo after their photoshoot on the 29th.
Not sure if we need/want to update the sidebar & model page heading to reflect that the section is for both lemp13 and lemp13-b. The firmware is different, but we didn't update the stickers, so someone looking at a lemp13-b will just see "lemp13" written on it. I don't think there will be any confusion about whether this section applies to them or not (it's not like there are any other lemp13 sections to mix it up with).