-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: enable OSH integration #2
base: main
Are you sure you want to change the base?
Conversation
@@ -14,6 +14,9 @@ upstream_package_name: polkit | |||
# downstream (Fedora) RPM package name | |||
downstream_package_name: polkit | |||
|
|||
# Enable Open Scan Hub integration | |||
osh_diff_scan_after_copr_build: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it wasn't necessary: https://packit.dev/posts/openscanhub-prototype. Did anything change on their side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's indeed not necessary, that was just an extra precaution given the prototype warning (https://packit.dev/docs/configuration#osh_diff_scan_after_copr_build) and also an excuse to not post a completely empty PR :)
But I'll probably drop it before I propose this to upstream, since only 41da136 should be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty PRs are better than PRs with a gazillion bugs :-)
only 41da136 should be needed
Makes sense. I didn't notice it's missing upstream.
By the way I opened polkit-org#517 and I wonder if the polkit project has access to that at all? If not I guess it should be possible to create a new project there to get the token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way I opened polkit-org#517 and I wonder if the polkit project has access to that at all? If not I guess it should be possible to create a new project there to get the token.
Given the Coverity project uses even the pre-gitlab URL I have my doubts about that, but maybe someone from the original maintainer team will still be available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. If all else fails it usually takes a couple of days for Coverity to approve new projects so access to that project isn't critical.
No description provided.