add missing metrics for disconnects and failed changesets

systemli · Mar 27, 2021 · 7720217 · 7720217
1 parent 7d5ed6e
commit 7720217
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/main.go b/main.go
@@ -25,7 +25,9 @@ type etherpadStats struct {
 	PendingEdits               int          `json:"pendingEdits"`
 	HttpRequests               httpRequests `json:"httpRequests"`
 	Connects                   meter        `json:"connects"`
+	Disconnects                meter        `json:"disconnects"`
 	Edits                      edits        `json:"edits"`
+	FailedChangesets           meter        `json:"failedChangesets"`
 	UeberdbLockAwaits          int          `json:"ueberdb_lockAwaits"`
 	UeberdbLockAcquires        int          `json:"ueberdb_lockAcquires"`
 	UeberdbLockReleases        int          `json:"ueberdb_lockReleases"`
@@ -105,9 +107,15 @@ etherpad_http_requests {{.HttpRequests.Meter.Count}}
 # HELP etherpad_connects
 # TYPE etherpad_connects gauge
 etherpad_connects {{.Connects.Count}}
+# HELP etherpad_disconnects
+# TYPE etherpad_disconnects gauge
+etherpad_connects {{.Disconnects.Count}}
 # HELP etherpad_edits
 # TYPE etherpad_edits gauge
 etherpad_edits {{.Edits.Meter.Count}}
+# HELP etherpad_failed_changesets
+# TYPE etherpad_failed_changesets gauge
+etherpad_failed_changesets {{.FailedChangesets.Count}}
 # HELP etherpad_ueberdb_locks
 # TYPE etherpad_ueberdb_locks gauge
 etherpad_ueberdb_locks{state="awaits"} {{.UeberdbLockAwaits}}

diff --git a/main_test.go b/main_test.go
@@ -39,9 +39,15 @@ etherpad_http_requests 15
 # HELP etherpad_connects
 # TYPE etherpad_connects gauge
 etherpad_connects 1
+# HELP etherpad_disconnects
+# TYPE etherpad_disconnects gauge
+etherpad_connects 0
 # HELP etherpad_edits
 # TYPE etherpad_edits gauge
 etherpad_edits 3
+# HELP etherpad_failed_changesets
+# TYPE etherpad_failed_changesets gauge
+etherpad_failed_changesets 0
 # HELP etherpad_ueberdb_locks
 # TYPE etherpad_ueberdb_locks gauge
 etherpad_ueberdb_locks{state="awaits"} 0
@@ -85,9 +91,15 @@ etherpad_http_requests 0
 # HELP etherpad_connects
 # TYPE etherpad_connects gauge
 etherpad_connects 0
+# HELP etherpad_disconnects
+# TYPE etherpad_disconnects gauge
+etherpad_connects 0
 # HELP etherpad_edits
 # TYPE etherpad_edits gauge
 etherpad_edits 0
+# HELP etherpad_failed_changesets
+# TYPE etherpad_failed_changesets gauge
+etherpad_failed_changesets 0
 # HELP etherpad_ueberdb_locks
 # TYPE etherpad_ueberdb_locks gauge
 etherpad_ueberdb_locks{state="awaits"} 0