Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option authType for s3 storage #394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

everpcpc
Copy link

@everpcpc everpcpc commented Jan 24, 2023

And add support for IAM and ENV auth for AWS S3.

Would possibly fix #386

@everpcpc everpcpc force-pushed the fix-auth branch 2 times, most recently from 38b069c to 3b2b0c3 Compare January 25, 2023 01:48
Dockerfile Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@turt2live
Copy link
Member

fwiw, the way s3 is handled is changing to be more cost effective. Auth will likely be part of that, but just a heads up that this PR might take a while to land because I want to make sure the rest of the stuff works before introducing more changes to worry about.

@everpcpc
Copy link
Author

@turt2live Hi, i've reverted the Dockerfile change and the minio-go upgrade.

@turt2live
Copy link
Member

Thanks for working on this. The codebase has changed pretty dramatically over the last year, but this is still something I'm interested in landing.

A current concern with this approach is users with multiple datastores can't specify multiple types of auth to use. If two datastores use environment variables, for example, only one will work (or both have to share those credentials, which is uncommon). Would it be possible to support multiple datastores in this setup?

@everpcpc
Copy link
Author

Official AWS client has profile support for these cases, but it seems minio-go dose not support that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement s3 Issues that are S3-specific
Projects
Development

Successfully merging this pull request may close these issues.

AssumeRole support for S3 datastores
2 participants