Adds error handling to browse node lookups, similar to those for items. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* aligns the error handling for browse node lookups with that of item lookups and searches * adds two tests for an invalid browse node
|
Hi @t3chnoboy. This change is similar to what is proposed in #43. Hopefully the style is more consistent and the test helps. Note that the CI should succeed with AWS_ID and AWS_SECRET set. Let me know what you think. Thanks! |
|
Looks great! Thank you @kaijuliu |
t3chnoboy
added a commit
that referenced
this pull request
Mar 18, 2016
Adds error handling to browse node lookups, similar to those for items.
|
Published as |
|
Thanks for fast merge and publish @t3chnoboy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and searches