perf: use packaging.version instead of distutils #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils has been removed since python 3.12
|
Thanks for the contribution! Before we can merge this, we need @Moraxyc to sign the Salesforce Inc. Contributor License Agreement. |
13 tasks
Have no idea why the bot said that again. |
|
The bot is somewhat less than 100% accurate, sadly. Thanks for following it up anyway :) |
|
I forgot to add the packaging package dependency. Considering that the commit of this PR has already been captured by nixpkgs as a patch, please add this part. |
jacalata
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils has been removed since python 3.12