remove some subquery and join constraints #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunocalza
force-pushed
the
bcalza/remove-constraints
branch
from
a5a1d81
to
b33ac93
Compare
brunocalza
requested review from
carsonfarmer,
joewagner and
avichalp
as code owners
brunocalza
requested review from
asutula and
dtbuchholz
and removed request for
carsonfarmer and
avichalp
dtbuchholz
reviewed
Aug 16, 2024
dtbuchholz
previously approved these changes
Aug 16, 2024
There was a problem hiding this comment.
lgtm! left a comment but feel free to ignore if it doesn't make sense...those can be done at the JS client, if needed
to unlock some studio use cases Signed-off-by: Bruno Calza <[email protected]>
brunocalza
force-pushed
the
bcalza/remove-constraints
branch
from
b33ac93
to
2adce4c
Compare
brunocalza
commented
Aug 16, 2024
| @@ -4772,99 +4772,39 @@ func TestLimits(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestDisallowSubqueriesOnStatements(t *testing.T) { | |||
| func TestAllowSubqueriesOnStatements(t *testing.T) { | |||
asutula
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the following constraints
cc @dtbuchholz @asutula
Context
https://linear.app/tableland/issue/ENG-877/allow-more-complex-sql-subqueries-in-parser