-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some subquery and join constraints #451
Conversation
a5a1d81
to
b33ac93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! left a comment but feel free to ignore if it doesn't make sense...those can be done at the JS client, if needed
to unlock some studio use cases Signed-off-by: Bruno Calza <[email protected]>
b33ac93
to
2adce4c
Compare
@@ -4772,99 +4772,39 @@ func TestLimits(t *testing.T) { | |||
}) | |||
} | |||
|
|||
func TestDisallowSubqueriesOnStatements(t *testing.T) { | |||
func TestAllowSubqueriesOnStatements(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @dtbuchholz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for getting this done.
Summary
This PR removes the following constraints
cc @dtbuchholz @asutula
Context
https://linear.app/tableland/issue/ENG-877/allow-more-complex-sql-subqueries-in-parser