test: add xls with oom allocations

tafia · Oct 27, 2024 · 1ffc325 · 1ffc325
1 parent c28cc12
commit 1ffc325
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/cfb.rs b/src/cfb.rs
@@ -273,12 +273,9 @@ impl Sectors {
         r: &mut R,
         len: usize,
     ) -> Result<Vec<u8>, CfbError> {
-        let mut chain = if len > 0 {
-            Vec::with_capacity(len)
-        } else {
-            Vec::new()
-        };
+        let mut chain = Vec::with_capacity(len);
         while sector_id != ENDOFCHAIN {
+            // FIXME: see tests/OOM_alloc3.xls, this call OOMs
             chain.extend_from_slice(self.get(sector_id, r)?);
             sector_id = fats[sector_id as usize];
         }

diff --git a/tests/OOM_alloc3.xls b/tests/OOM_alloc3.xls
diff --git a/tests/test.rs b/tests/test.rs
@@ -2147,4 +2147,6 @@ fn test_high_byte_strings_and_unicode_strings_without_reserved_tags() {
 fn test_oom_allocation() {
     let _xls: Xls<_> = wb("OOM_alloc.xls");
     let _xls: Xls<_> = wb("OOM_alloc2.xls");
+    // FIXME: kills all tests with abort unless unstable set_alloc_error_hook is used
+    // let _xls: Xls<_> = wb("OOM_alloc3.xls");
 }