fix(ods): support consecutive repeated empty cells #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #455
Explanation
We had two files:
single-empty.ods
that worked fine andmulti-empty.ods
that didn'tWhy? Because for
single-empty.ods
the XML behind it only has one empty withtable:table-row table:number-rows-repeated="7"
whereasmulti-empty.ods
has one empty, one withtable:table-row table:number-rows-repeated="4"
and then one withtable:table-row table:number-rows-repeated="2"
The code didn't support consecutive empty lines. I tried to make as little change as possible but there might well be a better way